fix: Fix packaging (missing __init__ module)#18
Merged
Conversation
oprypin
approved these changes
Mar 7, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out there never was an
__init__.pymodule in the package, and Poetry was fine with it, while PDM is a bit more strict about how it finds namespace packages. Also, the local configuration prevented earlier detection of this packaging issue. This is fixed by using theeditableseditable-backend which does not addsrcto PYTHONPATH when testing. Detection would be improved if PDM failed instead of falling back to thepathbackend, see pdm-project/pdm-backend#79.To further improve our practices,
--no-editableis now used in CI.Fixes issue pdm-project/pdm#17 and mkdocstrings/mkdocstrings#398