Skip to content

Fix strict mode in Docker by removing 0.0.0.0 warning #3784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lovelydinosaur merged 1 commit into from
Aug 23, 2024
Merged

Fix strict mode in Docker by removing 0.0.0.0 warning #3784

lovelydinosaur merged 1 commit into from
Aug 23, 2024
+44 −72

Conversation

@squidfunk
Copy link
Contributor

@squidfunk squidfunk commented Jul 26, 2024

Fixes #3724 and #2108. Consensus for this change was reached in #3724 (comment)

I'd suggest we simply don't enforce the check against 0.0.0.0. (#2022)
Less config is better. Less code is better.

This was referenced Jul 26, 2024
Closed
Closed
Closed
lovelydinosaur
lovelydinosaur approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@lovelydinosaur lovelydinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trusting the user here seems sensible, yep.

pawamoy
pawamoy approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@pawamoy pawamoy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) No mention of this to remove from the docs?

@squidfunk
Copy link
Contributor Author

squidfunk commented Jul 26, 2024

I searched for 0.0.0.0 but didn't find anything. I think since it's only a warning, the warning itself was not documented, and the general advise to not use the dev server for production would be, if mentioned in the docs, unaffected as it still holds.

@squidfunk squidfunk mentioned this pull request Aug 15, 2024
Merged
@lovelydinosaur lovelydinosaur merged commit e72c7d0 into mkdocs:master Aug 23, 2024
@lovelydinosaur lovelydinosaur mentioned this pull request Aug 29, 2024
Merged
@yashuatla yashuatla mentioned this pull request Jun 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lovelydinosaur lovelydinosaur lovelydinosaur approved these changes

+1 more reviewer

@pawamoy pawamoy pawamoy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Please allow running MkDocs with Docker and strict mode

3 participants

@squidfunk @lovelydinosaur @pawamoy