Skip to content

Fix shortcuts to go to previous or next page #3729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
squidfunk wants to merge 1 commit into from
Closed

Fix shortcuts to go to previous or next page #3729

squidfunk wants to merge 1 commit into from

Conversation

@squidfunk
Copy link
Contributor

@squidfunk squidfunk commented Jun 10, 2024

Fixes #3728.

@squidfunk squidfunk mentioned this pull request Jun 10, 2024
Closed
@squidfunk
Copy link
Contributor Author

squidfunk commented Jun 10, 2024

Not sure why the build fails. If it's related to my changes, let me know.

pawamoy
pawamoy approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's related to my changes, let me know.

Doesn't look like it.

Thanks!

@lovelydinosaur lovelydinosaur mentioned this pull request Jun 19, 2024
Merged
@lovelydinosaur
Copy link
Member

lovelydinosaur commented Jun 19, 2024

Doesn't look like it.

Eh... yeah resolved now.

Is it worth us bringing this up to date with master just to make sure we're keeping the builds clean?

@squidfunk
Copy link
Contributor Author

squidfunk commented Jun 21, 2024

Is it worth us bringing this up to date with master just to make sure we're keeping the builds clean?

I'm not sure I understand. What do you mean by clean? This PR is safe to merge regardless of #3730 (if that was your question), as both PRs fix unrelated things, and do not affect each other in any way.

@pawamoy
Copy link
Contributor

pawamoy commented Jun 21, 2024

I think @tomchristie meant to merge master / rebase on master to get the CI fix in this PR.

@squidfunk squidfunk closed this by deleting the head repository Jul 17, 2024
@lovelydinosaur
Copy link
Member

lovelydinosaur commented Jul 30, 2024

I think @tomchristie meant to merge master / rebase on master to get the CI fix in this PR

Exactly, yes.

@squidfunk squidfunk mentioned this pull request Jul 30, 2024
Merged
@squidfunk
Copy link
Contributor Author

squidfunk commented Jul 30, 2024

This PR was accidentally deleted. Please see #3787.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pawamoy pawamoy pawamoy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Default theme: N and P keys no longer work

3 participants

@squidfunk @lovelydinosaur @pawamoy