Add additional 'drafts' level to inclusion#3476
Conversation
9493d55 to
78a2c81
Compare
This comment was marked as abuse.
This comment was marked as abuse.
|
Sure, pick away. I know it's a breaking change, but it shouldn't be too bad for users. I think the addition of a "drafts" level makes it easier to understand the intention and behavior. |
78a2c81 to
006cf17
Compare
006cf17 to
1763292
Compare
|
Another option might be to deprecate the 'exclude_docs' setting and rename what 'exclude_docs' is doing in this PR to 'ignore'? That way folks using 'exclude_docs' will get a warning. |
This comment was marked as abuse.
This comment was marked as abuse.
1763292 to
1366d1c
Compare
|
@oprypin I think the The issue is that there isn't an additional way to ignore files in the
|
1366d1c to
0309783
Compare
|
Let me know if you have any more nit picks! I could "move" the |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
|
Thanks for the discussion, it's been a pleasure. I'll update my other PR after this one merges. |
oprypin
left a comment
There was a problem hiding this comment.
Thank you as well, and thanks for the patience
This change adds a "drafts" configuration option so that files can be appropriately marked as 'draft' to be included in the local server, and files that shouldn't be included at all are marked in 'exclude_docs'.
This change helps #3450 by allowing users to fully exclude paths.