Allow adding event handlers at multiple priorities #3448
Merged
+87
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-within one plugin.
Contributor
|
Why do you think this should be supported? |
Contributor
Author
|
I think a better question is why shouldn't it be supported. Right now it's a limitation based only on how it's implemented. If someone was designing this system anew, surely they wouldn't say that it's better that you can't have an early on_files handler if you already have a late handler for it. |
Contributor
|
Okay, so I read that there's no immediate need why this get's implemented, but it's a nice-to-have. From a plugin author's perspective, I'm not sure it's necessary, though. At least, I haven't seen one sound use case that would mandate for it. |
ultrabug
approved these changes
Nov 8, 2023
Member
ultrabug
left a comment
There was a problem hiding this comment.
I love the idea and can clearly see use cases, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-within one plugin.