Conversation
unless the page value is a *strict* subclass of Page
Contributor
|
LGTM. So, the regressions that we've seen should be gone, but judging from the code, you decided to issue warnings if a plugin overwrites |
squidfunk
approved these changes
Sep 10, 2023
This comment was marked as abuse.
This comment was marked as abuse.
Contributor
|
Thanks, yes, I was asking what the plans for 1.6 were, because the warning is not entirely clear to me: warnings.warn(
"A plugin has set File.page to an instance of Page and it got overwritten. "
"The behavior of this will change in MkDocs 1.6.",
DeprecationWarning,
)Will this be an error that terminates the build in MkDocs 1.6? |
This comment was marked as abuse.
This comment was marked as abuse.
Contributor
|
Perfect, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unless the page value is a strict subclass of Page
Page#3367 (comment)@squidfunk @ultrabug