Skip to content

Log excluded links only if referring page is included #3371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ChrisMayfield wants to merge 3 commits into from
Closed

Log excluded links only if referring page is included #3371

ChrisMayfield wants to merge 3 commits into from

Conversation

@ChrisMayfield
Copy link
Contributor

@ChrisMayfield ChrisMayfield commented Sep 5, 2023

I have several excluded folders in my site (via the exclude_docs setting). The excluded folders contain pages that refer to images and other files in the same folder. Would you consider not logging INFO messages for excluded targets when the referring page is also excluded?

For example, the three "Doc file ... contains a link" INFO lines below are repeated in the log every time I save a file and the site is rebuilt. These log entries are irrelevant, because the doc files are also excluded.

INFO    -  Building documentation...
INFO    -  Cleaning site directory
INFO    -  Doc file 'hw/hw4_draft.md' contains a link to 'hw/hw4_draft/rhody.py' which is excluded from the built site.
INFO    -  Doc file 'quiz/1a/written_v1.md' contains a link to 'quiz/1a/q1_code.svg' which is excluded from the built site.
INFO    -  Doc file 'quiz/1a/written_v2.md' contains a link to 'quiz/1a/q1_code.svg' which is excluded from the built site.
INFO    -  The following pages are being built only for the preview but will be excluded from `mkdocs build` per `exclude_docs`:
             - http://127.0.0.1:8000/cs149/hw/hw4_draft/
             - http://127.0.0.1:8000/cs149/quiz/1a/written_v1/
             - http://127.0.0.1:8000/cs149/quiz/1a/written_v2/

@oprypin
Copy link
Contributor

oprypin commented Sep 5, 2023 •
edited
Loading

The idea is good, I think I overlooked this.

The code is probably also good.

But it needs a new test. And in fact existing tests now seem to be failing for some reason

@oprypin oprypin mentioned this pull request Oct 29, 2023
Merged
@pawamoy pawamoy mentioned this pull request Jan 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ChrisMayfield @oprypin