Ensure each instance of Config is unique #2353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the global variable `mkdocs.config.DEFAULT_SCHEMA` with the function `mkdocs.config.defaults.get_schema()`. An instance is no longer created on import (eliminating circular imports under certain circumstances) and each call to `get_schema()` builds a new instance of each object. Fixes mkdocs#2289.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the global variable
mkdocs.config.DEFAULT_SCHEMAwiththe function
mkdocs.config.defaults.get_schema(). An instance is nolonger created on import (eliminating circular imports under certain
circumstances) and each call to
get_schema()builds a new instanceof each object. Fixes #2289.