Modify the syntax of version option and checking python version #2283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
snosratiershad
commented
Jan 12, 2021
- Use message and version arguments of click.version_option for better syntax instead string formatting.
- Modify pgk_dir typo.
- FIx pylint: C0103.
- DRY: remove repeated call of python version and add PYTHON_VERSION.
waylan
suggested changes
Jan 12, 2021
Member
waylan
left a comment
There was a problem hiding this comment.
This entire change seems completely unnecessary to me. But you have done the work and it is does update the code to Clicks current API. However, I have a couple concerned as described below. If you fix those, I'll merge this.
Contributor
Author
Ok, I will fix issues |
Contributor
Author
|
Thanks for reviews, I've tried to fix them, I wish it's will be OK |
waylan
reviewed
Jan 13, 2021
waylan
approved these changes
Jan 13, 2021
waylan
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.