Normalize IP addresses and change error to warning #2111
Merged
+25
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All IP addresses passed to `dev_addr` are now normalized. `127.000.000.001` is normalized to `127.0.0.1`. With apologies to docker container users, the address `0.0.0.0` no longer raises an error but a warning instead. Apparently, docker containers need to use that address, even in dev environments. Closes mkdocs#2108.
|
Thanks for this @waylan and all your effort maintaining makedocs. |
Closed
|
Not able run mkdoc server [::]:8000？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All IP addresses passed to
dev_addrare now normalized.127.000.000.001is normalized to127.0.0.1.With apologies to docker container users, the address
0.0.0.0no longer raises an error but a warning instead. Apparently,
docker containers need to use that address, even in dev environments.
Closes #2108.