Skip to content

v1.5.0 Attempts to Remove Files Twice, throws ValueError #3313

@Jake-Carter

Description

@Jake-Carter

I have a somewhat strange/niche site folder with an index.html, index.md, and a README.md.

After upgrading to v1.5.0, mkdocs build throws a ValueError with the trace below.

get_files will attempt to remove a file multiple times if there are multiple conflicts.

WARNING -  Excluding 'README.md' from the site because it conflicts with 'index.html'.
WARNING -  Excluding 'README.md' from the site because it conflicts with 'index.md'.
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/home/jakecarter/repos/fork/msdk/venv/lib/python3.11/site-packages/mkdocs/__main__.py", line 361, in <module>
    cli()
  File "/home/jakecarter/repos/fork/msdk/venv/lib/python3.11/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/jakecarter/repos/fork/msdk/venv/lib/python3.11/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/home/jakecarter/repos/fork/msdk/venv/lib/python3.11/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/jakecarter/repos/fork/msdk/venv/lib/python3.11/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/jakecarter/repos/fork/msdk/venv/lib/python3.11/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/jakecarter/repos/fork/msdk/venv/lib/python3.11/site-packages/mkdocs/__main__.py", line 286, in build_command
    build.build(cfg, dirty=not clean)
  File "/home/jakecarter/repos/fork/msdk/venv/lib/python3.11/site-packages/mkdocs/commands/build.py", line 299, in build
    files = get_files(config)
            ^^^^^^^^^^^^^^^^^
  File "/home/jakecarter/repos/fork/msdk/venv/lib/python3.11/site-packages/mkdocs/structure/files.py", line 371, in get_files
    files.remove(a)
ValueError: list.remove(x): x not in list

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions