(temporary) fix for 4.03 segfault#46
Merged
mjambon merged 5 commits intomjambon:masterfrom Jun 18, 2016
Merged
Conversation
Owner
|
Thanks for the detailed explanations and sorry for the delays. I'm going to release this. The next step for me is to get rid of |
This was referenced May 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following series of commits implements the work-around discussing in #45, using
Obj.magic (Sys.opaque_identity 0.0)instead ofObj.magic 0.0. I believe that the code is still wrong, but it segfaults strictly less¹. The long-term solution would be to use option references for field, but it is a more invasive change that I'd rather let @mjambon do, if he has the time before the next time it breaks.¹: without this patchset, atdgen's testsuite segfaults under 4.03 (with or without flambda), with the patchset it works. See the long comment in the "compiler internal" part of the testsuite for an attempt at an explanation.