Conversation
This reverts commit 70c3b8e.
ryotsun
reviewed
Jul 8, 2018
src/wp-includes/formatting.php
Outdated
| * @param int $number The number of words. Default 55. | ||
| */ | ||
| $excerpt_length = apply_filters( 'excerpt_length', 55 ); | ||
| $excerpt_length = apply_filters( 'excerpt_length', intval( $localized_excerpt_length ) ); |
tests/phpunit/includes/functions.php
Outdated
|
|
||
| /** | ||
| * Return true if `mb_*()` functions exist. | ||
| */ |
Collaborator
There was a problem hiding this comment.
コメント薄いですが、このファイルに関しては他の関数もコメント少ないですね…ｗ
tests/phpunit/includes/functions.php
Outdated
| /** | ||
| * Return true if `mb_*()` functions exist. | ||
| */ | ||
| function _mbfunctions_exist() { |
Collaborator
There was a problem hiding this comment.
この関数、まだ使われてないようですが、あとから使われる予定でしょうか？
memo: たぶん tests_add_filter() で追加
Collaborator
Author
There was a problem hiding this comment.
あー、そうなんです。Ozzさんという人と話したときに function_exists() はコストが高いので結果をキャッシュしたほうがいいよねみたいな話になって、こういう実装どうなん？みたいな話をしたのでメモ代わりと言うか。ｗ
Collaborator
Author
|
Merged at https://core.trac.wordpress.org/ticket/44541 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #2