fix: resolve db strict mode violation on initialization#885
Merged
tylerjroach merged 2 commits intomasterfrom Jan 22, 2026
Merged
fix: resolve db strict mode violation on initialization#885tylerjroach merged 2 commits intomasterfrom
tylerjroach merged 2 commits intomasterfrom
Conversation
…und worker thread. This avoids performing disk I/O during initialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the isFirstLaunch check from the main thread to a background thread.
Part of the check was to determine if a mixpanel db was already present on the device. Doing so requires reading from the filesystem and checking if the file exists, which is best handled on an IO thread.
MPDbAdapter now has a getter of
isNewDatabasethat is true if the db was already present on its initialization. This ensures we don't end up with a race condition of creating a db and checking if it exists.MPDbAdapter is now only initialized on the message queue (running on a background thread) ensuring all operations are async.
We now send a first open check to the message queue. It runs the first open check, and if it detects a first open, sends an event, then sets the shared prefs hasLaunched value.
FIRST_OPEN should still be the first event sent because it ends up the first message passed to the FIFO queue.