Add support for non-space indention#720
Merged
max-sixty merged 3 commits intomitsuhiko:masterfrom Feb 10, 2025
Merged
Conversation
- Adds support for non-space indention - even a "weird" mix of e.g. tabs and spaces. - Note, I had to add `String` field to the `Visitor` struct becasue the whitespace before the macro keyword is not included in the syn crate. - I only added a few new test cases with pure tabs or a combination of tabs and white spaces as most existing tests were also impacted by the change (and thus also tested the feature).
Contributor
Author
|
Sorry, nuked the old PR somehow. This fixes the conflicts and adds a changelog entry. |
Collaborator
|
Thank you @nicholassm ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stringfield to theVisitorstruct because the whitespace beforethe macro keyword is not included in the syn crate.
as most existing tests were also impacted by the change (and thus also tested the feature).