Conversation
…ingDescribeFromControl.spec.ts Signed-off-by: George Dias <gdias@mitre.org>
6 tasks
Signed-off-by: George Dias <gdias@mitre.org>
Signed-off-by: George Dias <gdias@mitre.org>
Signed-off-by: George Dias <gdias@mitre.org>
6 tasks
Signed-off-by: George Dias <gdias@mitre.org>
Signed-off-by: George Dias <gdias@mitre.org>
Closed
4 tasks
Signed-off-by: George Dias <gdias@mitre.org>
em-c-rod
reviewed
Mar 29, 2023
em-c-rod
reviewed
Mar 29, 2023
em-c-rod
reviewed
Mar 29, 2023
em-c-rod
reviewed
Mar 29, 2023
src/utilities/global.ts
Outdated
| } | ||
|
|
||
| const escapeSpecialCaseBackslashes = (s: string) => { | ||
| //return s.replace(/\\\)/g, '\\\\)'); // Escape backslashes if preceding close parentheses |
em-c-rod
reviewed
Mar 29, 2023
em-c-rod
reviewed
Mar 29, 2023
Contributor
em-c-rod
left a comment
There was a problem hiding this comment.
Left a couple comments, but looks good overall.
georgedias
commented
Mar 29, 2023
Contributor
Author
georgedias
left a comment
There was a problem hiding this comment.
done reviewing your comments.
Signed-off-by: George Dias <gdias@mitre.org>
Signed-off-by: George Dias <gdias@mitre.org>
Signed-off-by: George Dias <gdias@mitre.org>
em-c-rod
reviewed
Mar 31, 2023
|
|
||
| if (this.impact) { | ||
| result += ` impact ${this.impact}\n`; | ||
| if (this.impact !== undefined) { |
em-c-rod
approved these changes
Mar 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
getExistingDescribeFromControlreturn value needs to check if the last entry on the array is a blank line, it currently assumes that one exists, this causes invalid syntax being returned if there isn't a blank line at the end of the arrayUpdate the return with the following code
Happy Feet