Conversation
problems since our testing frameworks would basically instantly execute and not grant the time it took to do the dynamic import that using it in the real world would allow us to do. I replaced it with a simplified and handwritten pair of matching flatten and unflatten functions that handle our specific usecase of just threshold files with no options or fanciness. Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
…onality Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
…ly represent what it is doing Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
…ect could have depth of 2 or 3 depending on the top level attribute. it's also a partial object. Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
… to check both stdout and stderr Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
|
Contributor
Author
|
The code duplication is in the testing code which idk if sonarqube knows but is gonna end up lookin kinda similar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the 'flat' dependency since that was ESM only and causing problems since our testing frameworks would basically instantly execute and not grant the time it took to do the dynamic import that using it in the real world would allow us to do. I replaced it with a simplified and handwritten pair of matching flatten and unflatten functions that handle our specific usecase of just threshold files with no options or fanciness.