Remove version and release from inpect profile skeleton generator process#3767
Merged
georgedias merged 7 commits intomainfrom May 20, 2025
Merged
Remove version and release from inpect profile skeleton generator process#3767georgedias merged 7 commits intomainfrom
georgedias merged 7 commits intomainfrom
Conversation
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
em-c-rod
reviewed
May 15, 2025
| readmeObj.profileTitle = benchmarkTitle | ||
| readmeObj.profileVersion = `${stigVersion}.${stigRelease}.0` | ||
| readmeObj.inspecTitle = `${benchmarkTitle} :: Version ${stigVersion}, Release ${stigRelease} :: Benchmark Date: ${stigDate}` | ||
| readmeObj.inspecTitle = `${benchmarkTitle} :: Version ${stigVersion}, Release ${stigRelease} Benchmark Date: ${stigDate}` |
Contributor
There was a problem hiding this comment.
Will adding this here impact the GUI export in Heimdall? Have you tried to build Heimdall with this change in HDF converters and export a checklist through the GUI? If not, let me know and I can test that
Contributor
There was a problem hiding this comment.
Oh I see that this is the README title. Thanks for pointing it out!
em-c-rod
reviewed
May 16, 2025
Contributor
em-c-rod
left a comment
There was a problem hiding this comment.
I am still not fully clear if this is the right place to add the version and release to the InSpec title, but I know I am missing pieces of the whole picture.
em-c-rod
approved these changes
May 19, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restricted inspec title name to include version and release information