Skip to content

Update eMASSer to V3.22#3282

Merged
em-c-rod merged 27 commits intomainfrom
update-emasser-to-v3-22
Mar 6, 2025
Merged

Update eMASSer to V3.22#3282
em-c-rod merged 27 commits intomainfrom
update-emasser-to-v3-22

Conversation

@georgedias
Copy link
Contributor

@georgedias georgedias commented Feb 14, 2025

  • Implement @mitre/emass_client": "^3.22.0" package.
  • Fixed Threshold validation function
  • Reverted chai to baseline 4.x - 5.x is ECMAScript module based
  • Modified inspec_profile function to use the new fast-xml-parser version (5.0.7)
  • Added test suite for CIS benchmark (inspec_profile.test.ts)

@georgedias georgedias linked an issue Feb 14, 2025 that may be closed by this pull request
16 tasks
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@mergify
Copy link
Contributor

mergify bot commented Feb 18, 2025

This pull request has a conflict. Could you fix it @georgedias?

Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@georgedias georgedias force-pushed the update-emasser-to-v3-22 branch from 069bc7b to 799f700 Compare March 2, 2025 01:03
@mergify
Copy link
Contributor

mergify bot commented Mar 2, 2025

This pull request has a conflict. Could you fix it @georgedias?

Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@georgedias georgedias force-pushed the update-emasser-to-v3-22 branch from bc7692f to f34643c Compare March 4, 2025 22:59
@mergify
Copy link
Contributor

mergify bot commented Mar 4, 2025

This pull request has a conflict. Could you fix it @georgedias?

georgedias and others added 2 commits March 4, 2025 17:09
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@georgedias georgedias changed the title Update eMASSer to V3.12 Update eMASSer to V3.22 Mar 5, 2025
Copy link
Contributor

@em-c-rod em-c-rod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments. I left off reviewing here: src/commands/emasser/post/container_scans.ts

Copy link
Contributor

@em-c-rod em-c-rod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished review. Left a couple comments / questions, but looks really great.

Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@mergify
Copy link
Contributor

mergify bot commented Mar 6, 2025

This pull request has a conflict. Could you fix it @georgedias?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
3.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@em-c-rod em-c-rod merged commit 9f7d99e into main Mar 6, 2025
16 of 17 checks passed
@em-c-rod em-c-rod deleted the update-emasser-to-v3-22 branch March 6, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SAF CLI eMASSer Updates

2 participants