Skip to content

Delta process supporting fixes#3098

Merged
mergify[bot] merged 7 commits intomainfrom
updateControls4Delta
Dec 20, 2024
Merged

Delta process supporting fixes#3098
mergify[bot] merged 7 commits intomainfrom
updateControls4Delta

Conversation

@georgedias
Copy link
Contributor

@georgedias georgedias commented Dec 2, 2024 •
edited
Loading

  • When running the udadate_controls4delta without a profile json summary file an error is thrown due to the flag not being set.

georgedias and others added 5 commits December 2, 2024 11:15
@georgedias
Fixed case where inspec json file was not provided and logger would e…
17e0836 
…rror due to flag not set

Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@georgedias
Fixed deepsource code findings
1bab71a 
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@georgedias
Added documentation to the delta command
149ed77 
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@georgedias
Added documentation to the delta cli command
7a412cd 
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@DMedina6
Merge branch 'main' of https://github.com/mitre/saf into updateContro…
981787d 
…ls4Delta
DMedina6
DMedina6 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@DMedina6 DMedina6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Works on my end.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@georgedias georgedias added the ready-to-merge Used by mergify to identify if a PR is ready to merge into main. label Dec 20, 2024
@mergify mergify bot merged commit 72d31b3 into main Dec 20, 2024
@mergify mergify bot deleted the updateControls4Delta branch December 20, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DMedina6 DMedina6 DMedina6 approved these changes

Assignees

No one assigned

Labels

ready-to-merge Used by mergify to identify if a PR is ready to merge into main.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@georgedias @DMedina6