Skip to content

Update Controls4Delta logic to use XCCDF stub metadata#3046

Merged
mergify[bot] merged 7 commits intomainfrom
fix_update_controls4delta
Nov 20, 2024
Merged

Update Controls4Delta logic to use XCCDF stub metadata#3046
mergify[bot] merged 7 commits intomainfrom
fix_update_controls4delta

Conversation

@georgedias
Copy link
Contributor

@georgedias georgedias commented Nov 13, 2024 •
edited
Loading

  • Modify update_controls4delta to use xccdf metadata and describe block (code) from old control

@georgedias
updated profile_inspec and update_controls4delta to use xccdf stub me…
ba5c8a6 
…tadata

Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@georgedias
update tests to comply with oclif 4.1.0 - 80% completed
a3efd02 
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@georgedias
update tests to comply with oclif 4.1.0 - 80% completed
bd2f6f7 
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@georgedias georgedias self-assigned this Nov 18, 2024
@georgedias georgedias added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 18, 2024
georgedias and others added 2 commits November 19, 2024 22:15
@mergify
Copy link
Contributor

mergify bot commented Nov 20, 2024

This pull request has a conflict. Could you fix it @georgedias?

@georgedias georgedias changed the title Update logic to use XCCDF stub metadata Update Controls4Delta logic to use XCCDF stub metadata Nov 20, 2024
@georgedias
Removed unused npm modules
bcae031 
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

DMedina6
DMedina6 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@DMedina6 DMedina6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and makes sense.

@georgedias georgedias added the ready-to-merge Used by mergify to identify if a PR is ready to merge into main. label Nov 20, 2024
@mergify mergify bot merged commit eba20f1 into main Nov 20, 2024
@mergify mergify bot deleted the fix_update_controls4delta branch November 20, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DMedina6 DMedina6 DMedina6 approved these changes

@ejaronne ejaronne Awaiting requested review from ejaronne

Assignees

@georgedias georgedias

Labels

documentation Improvements or additions to documentation enhancement New feature or request ready-to-merge Used by mergify to identify if a PR is ready to merge into main.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@georgedias @DMedina6