Fix linkify of unicode identifiers#832
Merged
mhils merged 5 commits intomitmproxy:mainfrom Sep 16, 2025
Merged
Conversation
mhils
reviewed
Sep 16, 2025
Member
mhils
left a comment
There was a problem hiding this comment.
Thanks! Change looks great, but let's not pollute demo_long. Let's add this to misc please. :)
cb9f2d6 to
2612b27
Compare
2612b27 to
f3e405b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #831
I'm not sure if there might be a better place for the testdata I added here, but at least it shows what I'm actually fixing.
The desired change in the output can be seen here: ec1f716#diff-604417b9da1d286441ca229ba9380785833caa22a8ae36263a717c84d9f061c8R1700