Skip test_formatannotation_still_unfixed test on Python >= 3.10.1#349
Merged
mhils merged 2 commits intomitmproxy:mainfrom Feb 13, 2022
Merged
Skip test_formatannotation_still_unfixed test on Python >= 3.10.1#349mhils merged 2 commits intomitmproxy:mainfrom
mhils merged 2 commits intomitmproxy:mainfrom
Conversation
Contributor
Author
|
Though it'd be better to just skip that test... and I will be glad if someone explains to me why CI renders exactly |
Member
|
Thanks for the PR! 🍰 |
Co-authored-by: Roman Trapeznikov <roma190505@yandex.ru>
82fec54 to
fd0df3e
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
inspect.formatannotationwas fixed and it seems to have appeared in Python 3.10.1+. (Currently CI uses maximum 3.10.0).I'm curious why snapshots have
x: listannotations instead ofx: list[int]if they useformatannotationfromdoc_types.pywhich have a fix 🤔.