How do I tell the tests to use the updated mitmproxy_rs?

How do I tell the tests to use the updated mitmproxy_rs?

This currently requires us to ship a new release of mitmproxy_rs. There is an upper bound in https://github.com/mitmproxy/mitmproxy/blob/main/pyproject.toml#L45 though, so we can safely do that without affecting our users.

Regarding this PR: Could we just expose a get_system_dns_server() from Rust (that uses https://docs.rs/hickory-resolver/latest/hickory_resolver/system_conf/fn.read_system_conf.html internally) instead? We can then treat DNS mode just like we treat reverse DNS mode.

(We still need our getaddrinfo for mitmproxy.proxy.server - but the addon here we can maybe simplify dramatically 😃)

that uses https://docs.rs/hickory-resolver/latest/hickory_resolver/system_conf/fn.read_system_conf.html internally

This is available for UNIX only

that uses https://docs.rs/hickory-resolver/latest/hickory_resolver/system_conf/fn.read_system_conf.html internally

This is available for UNIX only

The docs are misleading here - it's available for Windows as well if you look at the sources. :)

I'm curious whether we will run into any issues with overly long records or so, but for now this is a great way forward

I don't think we'll run into this issue practically since we're only handling A/AAAA records(they typically won't cross the UDP limit). That TODO is a remnant of the old code and theoretically speaking, we may have a response size greater than the UDP limit that would need to be handled.

#6975 (comment) (unresolved comment above), otherwise LGTM :)

Sorry, messed up the commit history a bit while hopping between windows and linux. Should be fixed now

No worries, this is why we squash! :)