Build latest standalone binaries for Linux #6025

golariu · 2023-03-27T15:51:34Z

golariu
Mar 27, 2023

Hello,

My goal is to build standalone binaries using the latest proxy code. For that, I am running python release/build.py standalone-binaries at the end of which I get (during the verification part):

> mitmproxy --version
Traceback (most recent call last):
  File "mitmproxy", line 2, in <module>
ModuleNotFoundError: No module named 'mitmproxy'
[27939] Failed to execute script 'mitmproxy' due to unhandled exception!
Traceback (most recent call last):
  File "/<homedir>/mitmproxy/release/build.py", line 283, in <module>
    cli()
  File "/<homedir>/mitmproxy/venv/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/<homedir>/mitmproxy/venv/lib/python3.10/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/<homedir>/mitmproxy/venv/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    rv.append(sub_ctx.command.invoke(sub_ctx))
  File "/<homedir>/mitmproxy/venv/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/<homedir>/mitmproxy/venv/lib/python3.10/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/<homedir>/mitmproxy/release/build.py", line 125, in standalone_binaries
    _test_binaries(TEMP_DIR / "pyinstaller/dist")
  File "//mitmproxy/release/build.py", line 150, in _test_binaries
    subprocess.check_call([executable, "--version"])
  File "/usr/local/lib/python3.10/subprocess.py", line 369, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '[PosixPath('/<homedir>/mitmproxy/release/build/pyinstaller/dist/mitmproxy'), '--version']' returned non-zero exit status 1.

where <homedir> is my home path on this VM.

My questions:

I am wondering if anyone has stumbled upon this.
Given that the latest proxy requires Python 3.10 which is not available from public repositories, is there a recommended development workflow?

Details:

I use Rocky Linux 9.1.
I build Python 3.10.10 from source as I can't find an rpm for it.
The <homedir>/mitmproxy/venv/bin/mitm* binaries execute correctly.

Thanks,
gabriel

mhils · 2023-03-27T15:53:22Z

mhils
Mar 27, 2023
Maintainer

I hit the same issue yesterday here, what commit are you on?

6 replies

mhils Mar 27, 2023
Maintainer

Can you try to pip install ./mitmproxy instead of pip install -e ./mitmproxy and see if that fixes things?

golariu Mar 27, 2023
Author

My workflow is:

git clone https://github.com/mitmproxy/mitmproxy.git
cd mitmproxy
python3 -m venv venv
venv/bin/pip3 install -e ".[dev]"
source venv/bin/activate
python3 release/build.py standalone-binaries

Please advise what should I do differently.

mhils Mar 27, 2023
Maintainer

Instead of

venv/bin/pip3 install -e ".[dev]"

do

venv/bin/pip3 install ".[dev]"

I believe this is a PyInstaller bug.

golariu Mar 27, 2023
Author

Indeed:

> mitmproxy --version
Mitmproxy: 10.0.0.dev binary
Python:    3.10.10
OpenSSL:   OpenSSL 3.1.0 14 Mar 2023
Platform:  Linux-5.14.0-162.18.1.el9_1.x86_64-x86_64-with-glibc2.34
> mitmdump --version
Mitmproxy: 10.0.0.dev binary
Python:    3.10.10
OpenSSL:   OpenSSL 3.1.0 14 Mar 2023
Platform:  Linux-5.14.0-162.18.1.el9_1.x86_64-x86_64-with-glibc2.34
> mitmdump -s selftest.py
[12:16:51.732] Loading script <homedir>/mitmproxy/release/selftest.py
[12:16:51.738] HTTP(S) proxy listening at *:39073.
[12:16:51.829][127.0.0.1:56228] client connect
127.0.0.1:56228: GET https://mitm.it/
              << 200 OK 17.4k
[12:16:51.884][127.0.0.1:56228] client disconnect
[12:16:51.885] Self-test successful.
> mitmweb --version
Mitmproxy: 10.0.0.dev binary
Python:    3.10.10
OpenSSL:   OpenSSL 3.1.0 14 Mar 2023
Platform:  Linux-5.14.0-162.18.1.el9_1.x86_64-x86_64-with-glibc2.34
> mitmweb -s selftest.py
[12:16:55.176] Loading script <homedir>/mitmproxy/release/selftest.py
[12:16:55.182] HTTP(S) proxy listening at *:57413.
[12:16:55.184] Web server listening at http://127.0.0.1:8081/
[12:16:55.265][127.0.0.1:41878] client connect
[12:16:55.329][127.0.0.1:41878] client disconnect
[12:16:55.330] Self-test successful.

Thank you very much! I was going crazy knowing I had it working on Saturday!

mhils Mar 27, 2023
Maintainer

I've filed pyinstaller/pyinstaller#7524 for this! :)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Build latest standalone binaries for Linux #6025

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Replies: 1 comment 6 replies

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

Uh oh!

Build latest standalone binaries for Linux #6025

Uh oh!

Uh oh!

golariu Mar 27, 2023

Replies: 1 comment · 6 replies

Uh oh!

mhils Mar 27, 2023 Maintainer

Uh oh!

mhils Mar 27, 2023 Maintainer

Uh oh!

golariu Mar 27, 2023 Author

Uh oh!

mhils Mar 27, 2023 Maintainer

Uh oh!

golariu Mar 27, 2023 Author

Uh oh!

mhils Mar 27, 2023 Maintainer

golariu
Mar 27, 2023

Replies: 1 comment 6 replies

mhils
Mar 27, 2023
Maintainer

mhils Mar 27, 2023
Maintainer

golariu Mar 27, 2023
Author

mhils Mar 27, 2023
Maintainer

golariu Mar 27, 2023
Author

mhils Mar 27, 2023
Maintainer