Add 'shibboleth_authenticate_user' filter.#29
Open
boonebgorges wants to merge 2 commits intomitcho:masterfrom
Open
Add 'shibboleth_authenticate_user' filter.#29boonebgorges wants to merge 2 commits intomitcho:masterfrom
boonebgorges wants to merge 2 commits intomitcho:masterfrom
Conversation
This filter allows plugins to short-circuit the authentication of existing users and/or the provisioning of new users, based on whatever criteria they'd like.
Instead of returning `null` back to WP's authentication function, return the filtered value.
Author
|
On second thought, a better idea is to pass through the value returned by the filter, so that you can provide a |
Contributor
|
👍 This seems like a more user-friendly way of limiting access than using .htaccess |
|
Thanks for submitting this patch @boonebgorges. While I expect this is a little late, I released version 1.8 today to resolve this and other issues and included a shoutout for your patch. I am the new maintainer of the plugin and all further work on the plugin will be done in a new GitHub repository. If you have any further issues, please don't hesitate to report them in the new repository. |
Author
|
@michaelryanmcneill This sounds good. Thanks for following up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @mitcho!
I have a use case where I'd like to reject or allow authentication (for new or existing users) based on a custom header sent by the Shibboleth Apache module. There's no natural place in the plugin to intervene in the auth process, so I've introduced a new filter. My callback will look like this:
Thanks for considering!