[...].join() - handle null and better compress [...].join("str")#301
Closed
Skalman wants to merge 1 commit intomishoo:masterfrom
Closed
[...].join() - handle null and better compress [...].join("str")#301Skalman wants to merge 1 commit intomishoo:masterfrom
Skalman wants to merge 1 commit intomishoo:masterfrom
Conversation
* null, undefined, and holes in arrays are interpreted as an empty
string by Array.prototype.join. This commit fixes various issues when
compressing them, or values that can be null or undefined.
* Compress [foo+"str","123"+bar].join("-") -> foo+"str-123"+bar
|
+1 Holes is a problem for me too when compressing js-cookie (js-cookie/js-cookie#110). |
Contributor
|
Original |
|
oops. you're right. completely missed that |
Collaborator
|
This is probably outdated, so I'm closing this PR. Feel free to re-submit if you think it should be merged. |
This was referenced Jan 31, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
null,undefined, and holes in arrays are interpreted as an emptystring by
Array.prototype.join. This commit fixes various issues whencompressing them, or values that can be
nullorundefined.[foo+"str","123"+bar].join("-")->foo+"str-123"+barThe only issue that I can see now is that
[ "foo", bar + "baz" ].join("-")produces"foo-"+(bar+"baz"). I might fix that too.Btw, thanks for moving these out of
evaluate(). I find it difficult to know where to add code sometimes.