Merged
Conversation
- remove obsolete optimisation in `AST_Binary` after mishoo#1477 - improve `TreeWalker.has_directive()` readability and resilience against multiple visits
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AST_Binaryafter evaluate AST_SymbolRef as parameter #1477TreeWalker.has_directive()readability and resilience against multiple visitsJust things that I've discovered whilst working on #1593 which should be minimal and safe. The first part is covered by existing tests that comes with #1427, while the latter is covered by https://github.com/mishoo/UglifyJS2/blob/872270b14986b2f24df406425eda5a3bf7a3b56a/test/mocha/directives.js#L348-L369