fix chained assignment with unused#1540
Merged
alexlamsl merged 1 commit intomishoo:masterfrom Mar 2, 2017
Merged
Conversation
When mishoo#1450 optimises `a=b=42`, it stops after the first variable even if both are unused. fixes mishoo#1539
unsuedunused
kzc
reviewed
Mar 2, 2017
| } | ||
| expect: { | ||
| function f() { | ||
| return 42; |
Contributor
There was a problem hiding this comment.
How does this optimization take place at all with both reduce_vars and collapse_vars disabled?
Collaborator
Author
There was a problem hiding this comment.
sequence:
a = b = 42; return a;➡️return (a = b = 42), a;
side_effects + cascade:
(a = b = 42), a➡️b = 42
Collaborator
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
It's cascade. Never used that one before.
Collaborator
Author
There was a problem hiding this comment.
Well, it's on by default. I run into that when I was working on #1460
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When #1450 optimises
a=b=42, it stops after the first variable even if both are unused.