fix reference marking in for-in loops#1535
Merged
alexlamsl merged 1 commit intomishoo:masterfrom Mar 2, 2017
Merged
Conversation
This was referenced Mar 2, 2017
kzc
reviewed
Mar 2, 2017
| node.init.definition().fixed = false; | ||
| var d = node.init.definition(); | ||
| d.references.push(node.init); | ||
| d.fixed = false; |
Contributor
There was a problem hiding this comment.
Just curious why the symbol ref logic here differs somewhat from:
Collaborator
Author
There was a problem hiding this comment.
It's because with for (a in obj) {...}, node.init is just AST_SymbolRef which is a.
In theory I could extend isModified() to cover for-in loops, but putting it here is easier given the structure of the code.
Collaborator
Author
There was a problem hiding this comment.
Thanks for all the testing and hand-holding 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1533
/cc @kzc