fix mangling collision with keep_fnames (take 2)#1432
Closed
alexlamsl wants to merge 1 commit intomishoo:masterfrom
Closed
fix mangling collision with keep_fnames (take 2)#1432alexlamsl wants to merge 1 commit intomishoo:masterfrom
alexlamsl wants to merge 1 commit intomishoo:masterfrom
Conversation
Collaborator
Author
|
@kzc so this is the second attempt at fixing #1423 Aside from more code, turns out this doesn't just produce more optimal mangled result, but also fixed two extra corner cases I've come up with when |
Contributor
|
wrong test name: test/compress/issue-1423.js should be 1432.js |
Contributor
|
This PR is also fine. Default mangle speed is the same as Could you please move this fix into #1431 and close this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
options.keep_fnamesto preserve performance in the general case