Speedup unused compress option for already minified code#1024
Speedup unused compress option for already minified code#1024rvanvelzen merged 1 commit intomishoo:masterfrom kzc:speedup-unused
unused compress option for already minified code#1024Conversation
|
Before fix: After fix: |
|
Looks totally okay to me. Merged as 45ddb9c, thanks! |
|
I tested the fix against a dozen popular 200K+ minified JS files and a couple 1MB+ JS files and they had the same output My only concern was if any The fix doesn't slow down normal |
|
Do people need to do something specific to fix their problems with slow run-times for pre-minified code, or does it speed up things automatically? |
|
It works automatically. Note: this code has yet to be released on npm. |
|
Excited to see it released! It would literally cut my deployment time by 80% - most of my deployment is waiting for ugilfy to slog through the one or two minified files in my project. |
|
Interim workaround use compress option |
|
@kzc tried this workaround and it is at least building in 10 secs (before was 6 mins!). I'm raising a flag, guys, it is really awful performance. The file which should be minified is ~1.3mb |
|
uglify-js@2.6.2 does not contain this optimization. If I don't control when uglify-js releases are made. /cc @mishoo |
|
What do you mean? How it could help me? |
This PR fixed the |
|
The PR had release in @2.6.3 |
Fixes: #321 #917 #1022