fix corner case in booleans & conditionals (#5696)

alexlamsl · web-flow · commit 58d997a3d68e · 2022-10-04T12:58:55.000+08:00
diff --git a/lib/compress.js b/lib/compress.js
@@ -11592,7 +11592,7 @@ Compressor.prototype.compress = function(node) {
 
     function extract_lhs(node, compressor) {
         if (node instanceof AST_Assign) return is_lhs_read_only(node.left, compressor) ? node : node.left;
-        if (node instanceof AST_Sequence) return extract_lhs(node.tail_node());
+        if (node instanceof AST_Sequence) return extract_lhs(node.tail_node(), compressor);
         if (node instanceof AST_UnaryPrefix && UNARY_POSTFIX[node.operator]) {
             return is_lhs_read_only(node.expression, compressor) ? node : node.expression;
         }
diff --git a/test/compress/booleans.js b/test/compress/booleans.js
@@ -831,19 +831,36 @@ issue_5469: {
     expect_stdout: "undefined"
 }
 
-issue_5694: {
+issue_5694_1: {
     options = {
         booleans: true,
         conditionals: true,
     }
     input: {
-        var undefined;
+        var Infinity;
         // Node.js v0.12~6 (vm): 42
-        console.log((undefined = 42) && undefined);
+        console.log((Infinity = 42) && Infinity);
+    }
+    expect: {
+        var Infinity;
+        console.log((Infinity = 42) && Infinity);
+    }
+    expect_stdout: true
+}
+
+issue_5694_2: {
+    options = {
+        booleans: true,
+        conditionals: true,
+    }
+    input: {
+        var undefined;
+        // Node.js v0.12~6 (vm): NaN
+        console.log(("foo", ++undefined) || undefined);
     }
     expect: {
         var undefined;
-        console.log((undefined = 42) && undefined);
+        console.log(("foo", ++undefined) || undefined);
     }
     expect_stdout: true
 }

Original file line number	Diff line number	Diff line change
`@@ -11592,7 +11592,7 @@ Compressor.prototype.compress = function(node) {`
`11592`	`11592`
`11593`	`11593`	`function extract_lhs(node, compressor) {`
`11594`	`11594`	`if (node instanceof AST_Assign) return is_lhs_read_only(node.left, compressor) ? node : node.left;`
`11595`		`- if (node instanceof AST_Sequence) return extract_lhs(node.tail_node());`
	`11595`	`+ if (node instanceof AST_Sequence) return extract_lhs(node.tail_node(), compressor);`
`11596`	`11596`	`if (node instanceof AST_UnaryPrefix && UNARY_POSTFIX[node.operator]) {`
`11597`	`11597`	`return is_lhs_read_only(node.expression, compressor) ? node : node.expression;`
`11598`	`11598`	`}`