Conversation
Contributor
|
fine with me @hannesm :) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I massaged the commits of #329 slightly: no need for
ptimeintls-lwtright now, and add a dependency ontoptime >= 0.8.1(forPtime.v) into the opam file. This is only needed for the mirage subpackage, but we're not able to express this in opam (we could explicit create multiple packages (might be worth doing, but then we should also switch totopkg), or provide a newmirage-no-mirage(similar tomirage-no-xen/mirage-no-solo5) package (feels way to hacky)).Travis CI will not succeed with mirage since it uses mirage as released into opam-repository (and I don't think there's much value in moving this towards mirage-dev branches). Likely the example unikernels suffer from bitrot atm, but can be fixed in subsequent commits.
@mattgray I squashed your commits and amended the changes mentioned above. hope that's fine with you.