Skip to content

Add stop parameters in main-loop of server#5

Merged
avsm merged 2 commits intomirage:masterfrom
dinosaure:dinosaure-stop
May 31, 2014
Merged

Add stop parameters in main-loop of server#5
avsm merged 2 commits intomirage:masterfrom
dinosaure:dinosaure-stop

Conversation

@dinosaure
Copy link
Copy Markdown
Member

I think it must be possible to stop the server (on ocsigenserver, we should able to do this). I don't think this solutions is perfect in the details (relative with common trunk and Async) but it's the better for me.

@avsm
Copy link
Copy Markdown
Member

avsm commented May 27, 2014

Why not have an interrupt deferred, just as Async has? This would mean that stop is a unit Lwt.t and the main loop would exit if it ever becomes a concrete unit (as determined by Lwt.poll in the main loop).

That would help homogenize the interfaces between Async/Lwt...

@avsm avsm merged commit 944960a into mirage:master May 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants