Skip to content

use dune#631

Merged
mseri merged 2 commits intomirage:masterfrom
samoht:dune
Sep 6, 2018
Merged

use dune#631
mseri merged 2 commits intomirage:masterfrom
samoht:dune

Conversation

@samoht
Copy link
Copy Markdown
Member

@samoht samoht commented Sep 4, 2018

No description provided.

mseri
mseri approved these changes Sep 4, 2018
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mseri mseri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mseri
Copy link
Copy Markdown
Collaborator

mseri commented Sep 4, 2018

The tests are all failing, as if dune is ignoring the package directives in the tests stanzas:

Processing  1/2: [cohttp-lwt-jsoo: dune runtest]
+ /home/opam/.opam/4.04.2/bin/dune "runtest" "-p" "cohttp-lwt-jsoo" "-j" "71" (CWD=/home/opam/.opam/4.04.2/.opam-switch/build/cohttp-lwt-jsoo.1.0.2)
- File "cohttp-async/test/dune", line 4, characters 31-41:
- Error: Library "async_unix" not found.
- Hint: try: dune external-lib-deps --missing -p cohttp-lwt-jsoo @runtest
- File "cohttp-lwt-unix/test/dune", line 2, characters 13-28:
- Error: Library "cohttp-lwt-unix" not found.
- Hint: try: dune external-lib-deps --missing -p cohttp-lwt-jsoo @runtest
- File "cohttp-lwt-unix/test/dune", line 8, characters 33-48:
- Error: Library "cohttp-lwt-unix" not found.
- Hint: try: dune external-lib-deps --missing -p cohttp-lwt-jsoo @runtest
- File "cohttp/test/dune", line 2, characters 19-27:
- Error: Library "alcotest" not found.
- Hint: try: dune external-lib-deps --missing -p cohttp-lwt-jsoo @runtest

@samoht samoht mentioned this pull request Sep 6, 2018
Closed
@samoht
Copy link
Copy Markdown
Member Author

samoht commented Sep 6, 2018

Error reported upstream. I'll workaround the issue.

@mseri
Copy link
Copy Markdown
Collaborator

mseri commented Sep 6, 2018

Thanks. It's a pity that we had to revert those changes. Let's wait for Travis now, if the expected green is there it will be good for merge

@mseri
Copy link
Copy Markdown
Collaborator

mseri commented Sep 6, 2018 •
edited
Loading

All the failures are expected: debian unable to curl ounit or alpine image not present or incompatible with core. Merging

@mseri mseri merged commit ac41064 into mirage:master Sep 6, 2018
@samoht samoht deleted the dune branch September 7, 2018 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mseri mseri mseri approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samoht @mseri