Skip to content

Remove all instance of Lwt_log#608

Closed
rgrinberg wants to merge 1 commit intomirage:masterfrom
rgrinberg:remove-lwt-logs
Closed

Remove all instance of Lwt_log#608
rgrinberg wants to merge 1 commit intomirage:masterfrom
rgrinberg:remove-lwt-logs

Conversation

@rgrinberg
Copy link
Copy Markdown
Member

Use Logs exclusively. This makes us compatible with lwt 4.0 as well

Use Logs exclusively
@avsm
Copy link
Copy Markdown
Member

avsm commented Apr 11, 2018

lgtm

@raphael-proust
Copy link
Copy Markdown
Contributor

One nitpick: It changes the synchronous/asynchronous behaviour. Specifically, it only uses the Logs module which return unit instead of the Logs_lwt module which returns unit Lwt.t. In some cases, this is in line with the previous use, in other cases it's not.
See #609

One issue: In bin/cohttp_server_lwt.ml you do not set a reporter. According to Logs' documentation:

If you are writing an application you must remember to set the reporter before any logging operation takes place otherwise no messages will be reported.

@mseri
Copy link
Copy Markdown
Collaborator

mseri commented Oct 29, 2018

This has been superseded by #609, already merged. I am going to close. Feel free to reopen it if I am wrong

@mseri mseri closed this Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants