fixing parse of requests (#308)#317
Closed
zoggy wants to merge 6 commits intomirage:masterfrom
zoggy:master
Closed
fixing parse of requests (#308)#317zoggy wants to merge 6 commits intomirage:masterfrom zoggy:master
zoggy wants to merge 6 commits intomirage:masterfrom
zoggy:master
Conversation
lib/request.ml
Outdated
Member
There was a problem hiding this comment.
This really ought to be in Uri itself eventually. Complex semantics :/
Member
|
This fails against #318. |
Contributor
Author
|
Which tests are failing ? |
Contributor
Author
|
I think some tests should be fixed. I'll take the tests @dsheets added and commit some modifications. |
Member
|
There's not enough context here for me to understand what's going on. @dsheets I assume you'll take care of this. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.