Add mem function to KV_RO implementation.#99
Merged
yomimono merged 1 commit intomirage:masterfrom Oct 3, 2016
Merged
Conversation
6 tasks
Contributor
Author
|
I'd prefer for an ocaml-9p maintainer to take a look at this rather than merging myself. That said, I'm about to merge the mirage changes that necessitate this change, so if there are edits to this PR necessary it'd be nice to hear about them soon. |
Contributor
Author
|
...having just said that, I just hit |
talex5
reviewed
Oct 8, 2016
| stat t path | ||
| >>= function | ||
| | Ok stat -> return (`Ok true) | ||
| | _ -> return (`Ok false) |
Contributor
There was a problem hiding this comment.
The official 9p-approved way is to match on the error string I believe :-( Would be nice if the 9p client could map strings back to something sensible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suspect that translating any errors to
Unknown_keyis wrong and would appreciate any suggestions or followon PRs with better behavior.