This repository was archived by the owner on May 8, 2024. It is now read-only.
remove unneeded types (ethif, prefix) from module type IP#11
Merged
hannesm merged 5 commits intomirage:masterfrom Sep 14, 2018
hannesm:less-types
Merged
remove unneeded types (ethif, prefix) from module type IP#11hannesm merged 5 commits intomirage:masterfrom hannesm:less-types
hannesm merged 5 commits intomirage:masterfrom
hannesm:less-types
Conversation
This was referenced Aug 29, 2018
Member
Author
|
CI passes (including compilation of vpnkit), I'd really appreciate feedback on this, esp. if you've an opinion that |
Member
|
LGTM |
Member
Author
|
(to add some context, I suspect these were around back when |
Member
Author
|
adjusting (all?) upper bounds is PRed at ocaml/opam-repository#12562 and ocaml/opam-repository#12563 and ocaml/opam-repository#12564 version schedule:
all prepared in the https://github.com/mirage/mirage-dev repository |
5 tasks
14 tasks
Member
Author
|
(i PRed fixes for the CI failure to ocaml/opam-repository#12617 and mirage/ocaml-pcap#30) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I never understood why they need to be here. careful, this needs to be merged/released after the PRs to mirage-tcpip and charrua (anyone else has an IP implementation? sorry this may break your API)