Skip to content
This repository was archived by the owner on May 8, 2024. It is now read-only.

use mirage-runtime (and Mirage_pp instead of M_util)#50

Merged
hannesm merged 1 commit intomirage:masterfrom
hannesm:runtime
Nov 17, 2016
Merged

use mirage-runtime (and Mirage_pp instead of M_util)#50
hannesm merged 1 commit intomirage:masterfrom
hannesm:runtime

Conversation

@hannesm
Copy link
Copy Markdown
Member

@hannesm hannesm commented Nov 15, 2016

No description provided.

@talex5
Copy link
Copy Markdown
Contributor

talex5 commented Nov 15, 2016

I thought we wanted to make the error types private? e.g.

module type CONSOLE = sig
  type error = private [> `Disconnected | ...]
  ...
end

Having a central location for pretty printers will prevent that.

@hannesm
Copy link
Copy Markdown
Member Author

hannesm commented Nov 15, 2016

@talex5 thank you for your comment. I don't think this is the right place to discuss it, though. This change does not modify error handling, which was an earlier change. I also don't think that anything is carved into stone. Can we please discuss this on the mailing list so that it doesn't get lost?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants