Skip to content

PCLOCK / MCLOCK - implementations of POSIX and monotonic clocks#7

Merged
yomimono merged 31 commits intomirage:masterfrom
mattgray:new-clock-api
Aug 22, 2016
Merged

PCLOCK / MCLOCK - implementations of POSIX and monotonic clocks#7
yomimono merged 31 commits intomirage:masterfrom
mattgray:new-clock-api

Conversation

@mattgray
Copy link
Copy Markdown
Contributor

@mattgray
Copy link
Copy Markdown
Contributor Author

mattgray commented Jun 19, 2016

Should I rebase and squash some of these commits? There's a lot of WIP commits here

unix/mclock.mli Outdated
*)

val elapsed_ns : unit -> int64
val period_ns : unit -> int64 option
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this (and other interfaces) should specifically refer to V1.MCLOCK / V1.PCLOCK (something like include V1.MCLOCK)

@mattgray mattgray changed the title PCLOCK / MCLOCK - implementations of posix and monotonic clocks PCLOCK / MCLOCK - implementations of POSIX and monotonic clocks Jun 20, 2016
@yomimono
Copy link
Copy Markdown
Contributor

Sorry for the wait here -- a squash would be nice, but I might take a few liberties and do it myself if you don't have the time in the next couple of days (as long as you don't mind, of course).

@mattgray
Copy link
Copy Markdown
Contributor Author

I have a few things to add, namely DEVICE implementations for PCLOCK and
MCLOCK - those are done and I'm working thorough mirage-skeleton getting it
to compile. So if you want to hold off I can complete those and and then
squash? I hope to get skeleton building by the weekend, but at very least I
can push my changes here tomorrow

On Tuesday, 16 August 2016, Mindy Preston notifications@github.com wrote:

Sorry for the wait here -- a squash would be nice, but I might take a few
liberties and do it myself if you don't have the time in the next couple of
days (as long as you don't mind, of course).


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#7 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAnQSic3q8-X1CtfS7KORL6tHL42jHM2ks5qge8ggaJpZM4I4crk
.

@yomimono
Copy link
Copy Markdown
Contributor

Ah, I thought the DEVICE implementations were already here in ab8dd35 and 918faa6 ?

@mattgray
Copy link
Copy Markdown
Contributor Author

Ah did I push them already? Not at a computer so u can't check but if they
look legit then I probably did :)

On Tuesday, 16 August 2016, Mindy Preston notifications@github.com wrote:

Ah, I thought the DEVICE implementations were already here in ab8dd35
ab8dd35
and 918faa6
918faa6
?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#7 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAnQSjRQq2nZx0CtSEWkdk0FY4wC6J7Lks5qgffPgaJpZM4I4crk
.

@mattgray
Copy link
Copy Markdown
Contributor Author

s/u can't check/I can't check

On Tuesday, 16 August 2016, Matthew Gray matthew.thomas.gray@gmail.com
wrote:

Ah did I push them already? Not at a computer so u can't check but if they
look legit then I probably did :)

On Tuesday, 16 August 2016, Mindy Preston <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

Ah, I thought the DEVICE implementations were already here in ab8dd35
ab8dd35
and 918faa6
918faa6
?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#7 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAnQSjRQq2nZx0CtSEWkdk0FY4wC6J7Lks5qgffPgaJpZM4I4crk
.

@yomimono
Copy link
Copy Markdown
Contributor

They look legit to me; I'm working through downstream changes in mirage-logs and we'll see what make test says :P

@yomimono yomimono merged commit c8ae2d1 into mirage:master Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants