Skip to content

Qrexec expose#983

Closed
linse wants to merge 3 commits intomasterfrom
qrexec-expose
Closed

Qrexec expose#983
linse wants to merge 3 commits intomasterfrom
qrexec-expose

Conversation

@linse
Copy link
Copy Markdown
Collaborator

@linse linse commented Apr 29, 2019

We don't automatically invoke gui and qrexec for -t qubes anymore.
In QubesOS 3.2 it was necessary to start default handlers for all VMs,
otherwise QubesOS would assume the VM was not working properly and kill it
after 60 seconds. This is configurable in QubesOS 4, so now that
QubesOS 3.2 is past end-of-life, don't do it by default.
/cc @yomimono

linse added 3 commits April 29, 2019 21:36
in QubesOS 3.2 it was necessary to start default handlers for all VMs,
or QubesOS would assume the VM was not working properly and kill it
after 60 seconds.  This is configurable in QubesOS 4, so now that
QubesOS 3.2 is past end-of-life, don't do it by default.
Copy link
Copy Markdown
Contributor

@talex5 talex5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right; it looks like creating a standalone VM on Qubes 4 now defaults to having no qrexec (this is configured with qvm-features). I wonder if we should go further - do you think it's useful to keep qrexec support in the mirage tool at all? It seems like it can't select something else with the same interface for e.g. -t unix.

val default_qubesdb: qubesdb impl
(** A default qubes database, guessed from the usual valid configurations. *)

type qrexec
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some doc-comments are needed here. Most people reading this aren't going to know what qrexec (or Qubes) is.

@yomimono
Copy link
Copy Markdown
Contributor

I wonder if we should go further - do you think it's useful to keep qrexec support in the mirage tool at all? It seems like it can't select something else with the same interface for e.g. -t unix.

Hm, that's a good point. Less being more and all, I think that's the way to go.

@yomimono
Copy link
Copy Markdown
Contributor

(On further thought I think @linse suggested this too, and I had some half-baked idea about it being useful to have setup done before the unikernel starts, but after having slept on it I don't think that logic is very sound.)

@talex5
Copy link
Copy Markdown
Contributor

talex5 commented May 1, 2019

Closing in favour of #984 - thanks!

@talex5 talex5 closed this May 1, 2019
@hannesm hannesm deleted the qrexec-expose branch October 18, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants