WIP: extract and test a Mirage_cli module#928
Closed
emillon wants to merge 8 commits intomirage:masterfrom
Closed
Conversation
Member
|
As all your functions are named |
Contributor
Author
|
How would |
Member
|
I'm not convinced those are a great target for lifting them out but why not. You could make the code far less horrifying by just using |
Member
|
I'm closing this PR as it started to bit-rot. I like the general approach of having a better way to test the generated code, but as #933 has been merged, I think we should move all of these functions as top-level of their modules to ease testing. Will follow-up with new PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
While trying to understand how this package works, I noticed that the
Miragemodule does a lot of things. I'd like to make it a bit more modular, in particular to test some internals.This PR adds some characterization tests - just a way to dump the existing behavior so that we know about how these work and we can touch them without fear of breaking things. When/if this becomes possible, they can be replaced by lower level tests.
I have some questions:
Mirage_climodule OK, or should it be a bit more hidden (likeMirage.Private_clior underMirage.Codegen?)Mirage_codegenis more appropriate?Thanks!