Skip to content

rename M_pp to M_util (there'll be more than pp)#666

Merged
yomimono merged 1 commit intomirage:masterfrom
hannesm:rename
Nov 14, 2016
Merged

rename M_pp to M_util (there'll be more than pp)#666
yomimono merged 1 commit intomirage:masterfrom
hannesm:rename

Conversation

@hannesm
Copy link
Copy Markdown
Member

@hannesm hannesm commented Nov 12, 2016

M_pp is a pretty bad name since I plan to move e.g. functions for Stats there (into submodules). Thus rename early before we have too many dependencies... A travis build is good at mirage/mirage-dev#208

Best be merged with mirage/mirage-tcpip#264

@samoht
Copy link
Copy Markdown
Member

samoht commented Nov 14, 2016

I am not very fond of the M_util name. What about keeping the same conventions as Functiora and:

  • rename V1 into Mirage
  • rename M_util into Mirage_runtime

@hannesm
Copy link
Copy Markdown
Member Author

hannesm commented Nov 14, 2016

hmm, this might require some more thinking

  • the mirage package provides a mirage-runtime module (located in lib_runtime)
  • mirage and mirage-types are independent atm (on the opam level, there's no dependency between them)

--> does it sound better to leave mirage-types as the two interface files as before, and have runtime code in mirage.runtime (then mirage will depend on mirage-types, but that is fine I guess)?

@hannesm
Copy link
Copy Markdown
Member Author

hannesm commented Nov 14, 2016

turns out I do not understand the difference between lib_runtime/mirage_runtime.ml{i} and lib/mirage_key.ml{i} - the former contains the log_threshold (included in the latter), and both contain converters for ipv4/ipv6 addresses and prefixes... any insight (likely @Drup knows)?

@yomimono yomimono merged commit 8409e7f into mirage:master Nov 14, 2016
@hannesm hannesm deleted the rename branch November 14, 2016 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants