Skip to content

Fix serialisation of GC keys#1233

Merged
dinosaure merged 1 commit intomirage:mainfrom
samoht:fix-gc-keys
Oct 8, 2021
Merged

Fix serialisation of GC keys#1233
dinosaure merged 1 commit intomirage:mainfrom
samoht:fix-gc-keys

Conversation

@samoht
Copy link
Copy Markdown
Member

@samoht samoht commented Oct 8, 2021

No description provided.

@TheLortex
Copy link
Copy Markdown
Member

CI looking good, except for pgx: https://ci.mirage.io/job/2021-10-08/170103-ocluster-build-046e48

@samoht
Copy link
Copy Markdown
Member Author

samoht commented Oct 8, 2021

Is that error expected? Is this a new one?

@samoht
Copy link
Copy Markdown
Member Author

samoht commented Oct 8, 2021

Copying the error here to remember it:

/src/device-usage/pgx: (copy (src ./device-usage/pgx/)
                             (dst /src/device-usage/pgx))
2021-10-08 17:02.53 ---> saved as "b2f46409691c752807c1b72701a4703b0733578cd4f5a165646b7645dc4a2466"

/src/device-usage/pgx: (run (shell "opam exec -- mirage build"))
+ ocamlfind ocamlc -c -g -g -bin-annot -safe-string -principal -thread -strict-sequence -package tcpip.udpv4-socket -package tcpip.tcpv4-socket -package tcpip.stack-socket -package tcpip -package pgx_lwt_mirage -package pgx_lwt -package pgx -package mirage-unix -package mirage-types -package mirage-runtime -package mirage-logs -package mirage-crypto-rng-mirage -package mirage-clock-unix -package mirage-bootvar-unix -package lwt -package logs -w A-4-41-42-44-48 -o key_gen.cmo key_gen.ml
File "key_gen.ml", line 1:
Warning 70 [missing-mli]: Cannot find interface file.
+ ocamlfind ocamlc -c -g -g -bin-annot -safe-string -principal -thread -strict-sequence -package tcpip.udpv4-socket -package tcpip.tcpv4-socket -package tcpip.stack-socket -package tcpip -package pgx_lwt_mirage -package pgx_lwt -package pgx -package mirage-unix -package mirage-types -package mirage-runtime -package mirage-logs -package mirage-crypto-rng-mirage -package mirage-clock-unix -package mirage-bootvar-unix -package lwt -package logs -w A-4-41-42-44-48 -o unikernel.cmo unikernel.ml
File "unikernel.ml", line 9, characters 22-67:
9 |   module Pgx_mirage = Pgx_lwt_mirage.Make (RANDOM) (MCLOCK) (STACK)
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@TheLortex
Copy link
Copy Markdown
Member

TheLortex commented Oct 8, 2021

Ah yes we already have encountered that and it has been fixed in mirage-skeleton#master but not mirage-skeleton#mirage-dev

@dinosaure
Copy link
Copy Markdown
Member

Half of the CI work, we should merge.

@dinosaure dinosaure merged commit f4750b3 into mirage:main Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants