Basically -- what @talex5 said.

To precis an IRC chat with @hannesm yesterday:

This isn't fantastically important, but it was the first thing I noticed trying out Mirage3
There are apparently problems with Travis eating output lines using the "sophisticated" output of ocamlbuild hence the desire to default to "classic"
Reducing the number of things users can (mis-)configure is good, but my view is that tool display options reasonably could be user configurable

So-- if there are observed problems with Travis and sophisticated display then we certainly need to be able to use -classic-display, and we won't plumb through all the ocamlbuild CLI options to mirage. OTOH, it considerably clutters up output for those of us who build locally, and having different tools behave highly opinionatedly about the same thing without consensus seems rather silly.

The conclusion on IRC was that we really need the Mythical Build System :) In the interim, suggestions for sensible workaround welcome.

@hannesm did suggest those of us who want to turn off -classic-display could provide a local shell wrapper to ocamlbuild that removes that option. I've had a quick go at that but the combination of ocamlbuild's options and bash parameter quoting is defeating me currently.

(FWIW:

: mort@greyjay:noop#mirage-dev $= $; cat $(which ocamlbuild)
#! /bin/sh

set -ex

OCB=$(opam config var bin)/ocamlbuild
ARGS=$*

exec $OCB ${ARGS/ -classic-display/}

results in

: mort@greyjay:noop#mirage-dev $= $; make
ocamlbuild -use-ocamlfind -pkgs functoria.runtime,mirage-clock-unix,mirage-logs,mirage-types.lwt,mirage-unix,mirage.runtime -tags "thread,warn(A-4-41-44),debug,bin_annot,strict_sequence,principal,safe_string" -tag-line "<static*.*>: warn(-32-34)" -cflag -g -lflags -g,-linkpkg main.native
++ opam config var bin
+ OCB=/Users/mort/.opam/mirage-dev/bin/ocamlbuild
+ ARGS='-use-ocamlfind -pkgs functoria.runtime,mirage-clock-unix,mirage-logs,mirage-types.lwt,mirage-unix,mirage.runtime -tags thread,warn(A-4-41-44),debug,bin_annot,strict_sequence,principal,safe_string -tag-line <static*.*>: warn(-32-34) -cflag -g -lflags -g,-linkpkg main.native'
+ exec /Users/mort/.opam/mirage-dev/bin/ocamlbuild -use-ocamlfind -pkgs functoria.runtime,mirage-clock-unix,mirage-logs,mirage-types.lwt,mirage-unix,mirage.runtime -tags 'thread,warn(A-4-41-44),debug,bin_annot,strict_sequence,principal,safe_string' -tag-line '<static*.*>:' 'warn(-32-34)' -cflag -g -lflags -g,-linkpkg main.native
Command-line "<static*.*>:", line 1, character 12:
Lexing error: Invalid tag modifier only '+ or '-' are allowed as prefix for tag.
Compilation unsuccessful after building 0 targets (0 cached) in 00:00:00.
make: *** [main.native] Error 8

)

Imposition of -classic-display #761

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Imposition of `-classic-display` #761