HTTP tests: have a separate pid and socket file per test suite#1062
Merged
samoht merged 6 commits intomirage:masterfrom Aug 12, 2020
Merged
HTTP tests: have a separate pid and socket file per test suite#1062samoht merged 6 commits intomirage:masterfrom
samoht merged 6 commits intomirage:masterfrom
Conversation
otherwise the file's mode is set read-only by dune and that fails if you run the test twice.
Member
Author
|
There were indeed still a race where a previous test could delete the pid file of the next one. I have no idea how this could be happening, still investigating. But I've made sure every test have their own pid file, to avoid this being removed accidentally. With that change I think we don't need the test locks anymore (will test that in another PR once I managed to fix the flakiness). |
33b693f to
418631d
Compare
Member
Author
|
All green from first run 🎉 The remaining issue is the ppx one (same as #1060 (comment) but @craigfe is working on a fix) |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.