This repository was archived by the owner on Aug 25, 2022. It is now read-only.
Remove base_context & fix error messages when config compilation fails#65
Merged
yomimono merged 4 commits intomirage:masterfrom Jul 19, 2016
Merged
Remove base_context & fix error messages when config compilation fails#65yomimono merged 4 commits intomirage:masterfrom
yomimono merged 4 commits intomirage:masterfrom
Conversation
Member
|
LGTM! |
f040db7 to
cca28e0
Compare
Contributor
Author
|
Hearing no objections here or on the mailing list thread, I'll merge this... |
| (* 2. Load the config from the config file. *) | ||
| (* First, set the base context ref, which might be accessed in the | ||
| config file. *) | ||
| let () = Config'.base_context_ref := base_context in |
Member
There was a problem hiding this comment.
I think the case 3. of the comment just bellow is not valid anymore. ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes uses of, and references to,
base_context. In combination with the required downstream Mirage changes, fixes mirage/mirage#461 .