This repository was archived by the owner on Aug 25, 2022. It is now read-only.
Expand the signature Functoria.Key manually.#153
Merged
hannesm merged 1 commit intomirage:masterfrom Jul 28, 2018
Merged
Conversation
This was referenced Jul 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The semantics of
module type of struct include X endwas changed by @lpw25 in 4.07. It now produces module aliases instead of expanding to the inner types. Since we use this signature to extend the modules inMirage, it doesn't work anymore. This version manually expand all the type equalities.This means that if we were to add a new types in
Functoria_key, we need to add the equality here. If you think it's madness, I don't disagree. Hopefully we will have a better solution in 4.08.This change should be fully backward compatible and can be used in any OCaml version.
In conjunction with mirage/mirage#912, Fixes mirage/mirage#911